-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix regression: add back detail to tool-call banners #3231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
katzdave
merged 1 commit into
block:main
from
LordMelkor:feature/tool-call-extension-names
Jul 16, 2025
Merged
Fix regression: add back detail to tool-call banners #3231
katzdave
merged 1 commit into
block:main
from
LordMelkor:feature/tool-call-extension-names
Jul 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e786081 to
59d8ccf
Compare
Contributor
Author
Updates Based on FeedbackI've simplified the PR significantly: Changes Made:
Result:Tool banners now show clean, focused descriptions:
Technical Details:
The PR now addresses the original issue from #3104 without adding user-facing complexity. The core problem (unknown tools showing poor descriptions) is fixed while keeping the implementation clean and maintainable. |
This was referenced Jul 3, 2025
59d8ccf to
6de0983
Compare
- Fix generic tool fallback to show meaningful descriptions (ToolName + arguments) - Update comments to describe current functionality rather than historical references - Remove references to "old system" and outdated implementation details - Improve code readability for developers unfamiliar with historical context - Ensure all MCP tools display properly with fallback formatting This addresses tool display issues where some tools showed only argument keys instead of meaningful descriptions, and cleans up confusing historical references in code comments.
842af01 to
d50dabe
Compare
DOsinga
approved these changes
Jul 16, 2025
katzdave
approved these changes
Jul 16, 2025
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 17, 2025
* main: feat(gcpvertexai): do HTTP 429 like retries for Anthropic API HTTP 529 overloaded status code (#3026) Fix a few ui edge cases - refresh occasionally crashing, chat loader over text and chat input height returning to auto (#3469) Don't default to main for build-cli (#3467) docs: add MongoDB MCP server tutorial (#2660) feat: run sub recipe multiple times in parallel (Experimental feature) (#3274) chore(release): release version 1.1.0 (#3465) chore: implement streaming for anthropic.rs firstparty provider (#3419) Fix regression: add back detail to tool-call banners (#3231) Document release process and update some just recipes (#3460) feat: add download_cli.ps1 file for windows (#3354) fix: session_file is optional (#3462) Bump more space for goose is working on it so it doesnt overlap incoming agent chat messages (#3453) Align chat input action buttons to bottom when large amount of text (#3455) docs: add Cloudflare MCP Server tutorial (#3278) feat(cli): Clear persisted session file with /clear command (#3145)
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Problem
PR #3104 (commit 666ce69) swapped our generic tool-banner logic for a short hard-coded switch. As a result, unknown MCP tools were reduced to showing only a single argument key ("directory") and lost both the tool name context.
✨ What's Fixed
writing src/file.tswithout clutterToolName key1, key2 …(with truncation)🛠 Implementation
ToolCallWithResponse.tsx
ToolName keysfallback for unknown toolsResponseStylesSection.tsx
Removed Infrastructure
✅ Testing
Verified that:
running commandToolName arguments🎯 Result
Tool banners are now clean and focused while preserving full functionality:
[Extension: developer] writing /path/to/file.tswriting /path/to/file.tsThis addresses the core issue from #3104 with a simple, maintainable solution that doesn't add UI complexity or feature-specific infrastructure.